Re-export secp256k1_zkp #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think re-exporting secp-zkp is a good idea (bitcoin could be as well), but I'm not sure about adding features that are used only for outside purpose. Though it's inconvenient I think the proper way is for you to import it in your project and enable the features you need. |
|
the
|
|
tACK Master, nor 0.4, would compile without this |
Got it SGTM then. |
Tibo-lg
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-exports
secp256k1_zkpsince a lof of the types are leaked in the API and just makes it easier to get from rust-dlc instead of having to import the library yourself. Needed to enable the rand-std flag for external use too.Also makes
read_dlc_messagepublic so you can manually parse dlc messages externally.