Fix sample cli and bitcoin rpc provider #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibo-lg
force-pushed
the
fix/sample-and-cli-test
branch
13 times, most recently
from
8c1da20 to
952d18c
Compare
|
tACK 👍 Got an error with the changing Can make a PR for that |
luckysori
approved these changes
Apr 3, 2024
Comment on lines
+394
to
+404
| match self | ||
| .client | ||
| .lock() | ||
| .unwrap() | ||
| .unlock_unspent(outpoints) | ||
| .map_err(rpc_err_to_manager_err)? | ||
| { | ||
| true => Ok(()), | ||
| false => Err(ManagerError::StorageError(format!("Failed to unlock utxos: {outpoints:?}"))) | ||
| false => Err(ManagerError::StorageError(format!( | ||
| "Failed to unlock utxos: {outpoints:?}" | ||
| ))), |
There was a problem hiding this comment.
Is this just a formatting change? Maybe this wasn't intentional.
On a similar note, I often get formatting conflicts when working on rust-dlc since I use auto-formatting on save. Are we using rustfmt or not?
Tibo-lg
force-pushed
the
fix/sample-and-cli-test
branch
from
952d18c to
3b48432
Compare
|
Closes #209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.