Update bitcoin node version #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibo-lg
requested changes
Jul 10, 2024
docker-compose.yml
Outdated
| @@ -2,7 +2,7 @@ version: "3.4" | |||
| services: | |||
| ### BITCOIND | |||
| bitcoind: | |||
| image: ruimarinho/bitcoin-core:0.20.0 | |||
| image: kylemanna/bitcoind:latest | |||
There was a problem hiding this comment.
I don't like to use latest because things then break unexpectedly.
sample/Readme.md
Outdated
| @@ -8,6 +8,8 @@ Example configurations and contract input are available in the [examples](./exam | |||
| In order to use the [example contract](./examples/contracts/numerical_contract_input.json) you will need to update the `event_id`. | |||
| Replace the part after `btcusd` with a UNIX timestamp in the future. | |||
|
|
|||
| Use the [helper script](../scripts/gen-sample-offer.sh) to create update the example contract 1 hour in the future. This replaces the `event_id` after `btcusd` with a UNIX timestamp 1 hour in the futre. Manually update the value for a longer time period. | |||
There was a problem hiding this comment.
Suggested change
| Use the [helper script](../scripts/gen-sample-offer.sh) to create update the example contract 1 hour in the future. This replaces the `event_id` after `btcusd` with a UNIX timestamp 1 hour in the futre. Manually update the value for a longer time period. | |
| Use the [helper script](../scripts/gen-sample-offer.sh) to create the example contract 1 hour in the future. This creates an `event_id` with a UNIX timestamp 1 hour in the future. Manually update the value for a longer time period. |
|
If you rebase on master the clippy errors should be gone. |
bennyhodl
force-pushed
the
update-bitcoin-node
branch
from
cbbee6a to
b449eaf
Compare
Tibo-lg
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a script
gen-sample-contract.shthat creates a contract an hour in the future instead of manually editing.Updates the bitcoin-core image to the latest. In doing this, the wallets have to be legacy for the RPC client to work. The RPC client will have to update to use descriptors in the
derive_contract_signermethod.