Trap exceptions also via $SIG{__DIE__} handler in case it would be cleared by stack-unwinding #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eared by stack-unwinding It fixes one TODO test for older perl version, plus there are added lot of other tests.
|
@karenetheridge can you look at review this pull request? |
|
I've taken a look, but I'm not confident that it's doing the right thing. Given this module's position on the cpan river (it's the very top module that is not dual-lifed) I need to be extremely cautious about merging changes, and will not merge any changes of consequence without sign-off from at least a few people who know this area, and the edge cases that are effected. |
|
@karenetheridge so who should do code review for this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes one TODO test for older perl version, plus there are added lot of other tests.