Fix issues with calculate_qw_pixels2 for recent horace #1751
Conversation
oerc0122
force-pushed
the
fix-calc-qw-pix2
branch
from
c8b7757 to
7f33451
Compare
oerc0122
force-pushed
the
fix-calc-qw-pix2
branch
from
7f33451 to
f886f6e
Compare
| if ~iscell(win.header) | ||
| header = {win.header}; | ||
| header = num2cell(win.header)'; |
There was a problem hiding this comment.
To be fair, we should not use header in new code. This is legacy method, necessary for writing old format sqw files and may be in some printing (also legacy, no time to throw it from there)
This is probably another ticket though.
There was a problem hiding this comment.
What is the new alternative?
There was a problem hiding this comment.
Experiment.IX_experiment or sqw.experiment_info.expdata
| function detdcn = spec_coords_to_det (detpar) | ||
| % Matrix to convert coordinates in spectrometer (or laboratory) frame into detector frame | ||
| % | ||
| % >> d_mat = spec_coords_to_det (detpar) |
There was a problem hiding this comment.
This is code duplication as something similar is in rundatah/convert_to_sqw. Which one is better I do not know, as see some optimization here too. Probably other ticket again.
There was a problem hiding this comment.
A whole chunk of this including calculate_qw_pixels2 is duplicated in rundatah (c.f. rundatah.calc_qspec) and the whole thing needs to be split off into utilities at some point, but like you say, not this ticket.
Update function to work with unique_references_container, struct-array header and use established functions.
This will likely be used in the on-the-fly re-computation of pixels.
Fixes #1152