Skip to content

Commit

Permalink
fix: fix typos in the exceptions for limits (#558)
Browse files Browse the repository at this point in the history
After switching our deployment to MP+ we (read as “me”) missed some
occurences of hardcoded project/namespace for Packit Service deployment.

* Fix those typos.
* Add warning to the template.
  • Loading branch information
mfocko authored Mar 7, 2024
2 parents ef16bbc + 8566f05 commit e14347d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion openshift/packit-service.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ spec:
# If you see '/usr/bin/run_httpd.sh: line 16: Killed alembic upgrade head'
# you have to temporarily increase (in webUI/console) the limit
# and once the alembic upgrade passes, revert.
memory: "{{ '4Gi' if project == 'packit-prod' else '512Mi' }}"
memory: "{{ '4Gi' if project == 'packit--prod' else '512Mi' }}"
cpu: "200m"
# In TLS world, hostname needs to match whatever is set in the cert
# in our cause, k8s is doing here something like curl https://172.15.2.4:8443/api/healthz/
Expand Down
4 changes: 2 additions & 2 deletions openshift/postgres.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,12 @@ spec:
# - /usr/libexec/check-container
resources:
requests:
memory: "{{ '2Gi' if project == 'packit-prod' else '128Mi' }}"
memory: "{{ '2Gi' if project == 'packit--prod' else '128Mi' }}"
cpu: "30m"
limits:
# The shared_buffers & effective_cache_size values are set by the container
# based on this limit, so keep the limit reasonably high.
memory: "{{ '4Gi' if project == 'packit-prod' else '256Mi' }}"
memory: "{{ '4Gi' if project == 'packit--prod' else '256Mi' }}"
# Not utilized most of the time, but useful during migrations and for some queries
cpu: "1"
volumeMounts:
Expand Down
4 changes: 3 additions & 1 deletion vars/packit/prod_template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
# -------------------------------------------------------------------

# Openshift project/namespace name
project: packit-prod
# [WARNING] Be careful when changing this value as it is explicitly checked in
# the Packit Service (API) and postgresql deployments
project: packit--prod

# Openshift cluster url
# For the URL of the MP+ API endpoint, see Bitwarden Secure note
Expand Down

0 comments on commit e14347d

Please sign in to comment.