Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix base image build #624

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix base image build #624

merged 1 commit into from
Dec 10, 2024

Conversation

nforro
Copy link
Member

@nforro nforro commented Dec 10, 2024 •
edited
Loading

I don't know what's wrong, it looks like OpenSSL on Fedora 41 ppc64le doesn't support SHA384 (but I'm not able to reproduce it outside of Github Actions environment):

$ openssl s_client -servername mirrors.fedoraproject.org -connect mirrors.fedoraproject.org:443 < /dev/null
Connecting to 140.211.169.196
depth=2 C=US, O=DigiCert Inc, OU=www.digicert.com, CN=DigiCert Global Root G3
verify return:1
depth=1 C=US, O=DigiCert Inc, CN=DigiCert Global G3 TLS ECC SHA384 2020 CA1
verify error:num=7:certificate signature failure
verify return:1
depth=1 C=US, O=DigiCert Inc, CN=DigiCert Global G3 TLS ECC SHA384 2020 CA1
verify return:1
depth=0 C=US, ST=North Carolina, L=Raleigh, O=Red Hat, Inc., CN=*.fedoraproject.org
verify error:num=7:certificate signature failure
verify return:1
depth=0 C=US, ST=North Carolina, L=Raleigh, O=Red Hat, Inc., CN=*.fedoraproject.org
verify return:1

Disabling certificate verification is an ugly workaround, but it makes it work:
https://github.com/packit/deployment/actions/runs/12256772166

@nforro nforro force-pushed the alternative-arches branch from 0af1f7c to c9286eb Compare December 10, 2024 11:32
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro force-pushed the alternative-arches branch from c9286eb to aa94887 Compare December 10, 2024 11:37
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro force-pushed the alternative-arches branch from aa94887 to ceee5ff Compare December 10, 2024 11:41
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro force-pushed the alternative-arches branch from ceee5ff to a999c02 Compare December 10, 2024 11:52
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro force-pushed the alternative-arches branch from a999c02 to 0ba7d36 Compare December 10, 2024 11:57
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro force-pushed the alternative-arches branch from 0ba7d36 to 69dbf94 Compare December 10, 2024 12:04
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro force-pushed the alternative-arches branch from 69dbf94 to 62e35ee Compare December 10, 2024 12:09
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro force-pushed the alternative-arches branch from 62e35ee to bfea1a7 Compare December 10, 2024 12:14
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro force-pushed the alternative-arches branch from bfea1a7 to b06e2bd Compare December 10, 2024 12:20
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro force-pushed the alternative-arches branch from b06e2bd to b3ab4cd Compare December 10, 2024 12:36
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro force-pushed the alternative-arches branch from b3ab4cd to 9f42738 Compare December 10, 2024 12:45
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro force-pushed the alternative-arches branch from 9f42738 to a9e5f4e Compare December 10, 2024 12:49
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@nforro nforro force-pushed the alternative-arches branch from a9e5f4e to cce38d8 Compare December 10, 2024 13:08
@softwarefactory-project-zuul softwarefactory-project-zuul

This comment was marked as outdated.

Sign in to view
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/82600244458c478fa23ae7652a15817a

✔️ pre-commit SUCCESS in 1m 39s

@nforro nforro marked this pull request as ready for review December 10, 2024 13:48
mfocko
mfocko approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@mfocko mfocko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like this though :D

@nforro
Copy link
Member Author

nforro commented Dec 10, 2024

It looks like this is the missing step that we would have to do before pushing, create a manifest with all 3 images:

Creating manifest base:fedora
/usr/bin/buildah manifest create base:fedora
42598485a935ec09b6059cc9c940b1d70721a66a58a2a139650f362c7f010dda
Adding image "base:fedora-amd64" to the manifest.
/usr/bin/buildah manifest add base:fedora base:fedora-amd64
42598485a935ec09b6059cc9c940b1d70721a66a58a2a139650f362c7f010dda: sha256:c2b49e0c4c3bc66f173f7bb20163eb8e0e1cf0abd52a11b8b222a15e46846b0f
Adding image "base:fedora-arm64" to the manifest.
/usr/bin/buildah manifest add base:fedora base:fedora-arm64
42598485a935ec09b6059cc9c940b1d70721a66a58a2a139650f362c7f010dda: sha256:2fc94eab813390e32341a152267d735afc11cbb5348a1f768483d652849ee550
Adding image "base:fedora-ppc64le" to the manifest.
/usr/bin/buildah manifest add base:fedora base:fedora-ppc64le
42598485a935ec09b6059cc9c940b1d70721a66a58a2a139650f362c7f010dda: sha256:3[377](https://github.com/packit/deployment/actions/runs/12257420183/job/34194841795#step:4:379)905ed81aab0cb71d9fe0889dd321bbcbd46ac7c2903991680530721e5720

https://github.com/packit/deployment/actions/runs/12257420183/job/34194841795#step:4:370

@nforro
Copy link
Member Author

nforro commented Dec 10, 2024

Actually, thinking about it, we'll have the same problem in all containers based on this image, and probably not just with dnf. Let's disable ppc64le for now.

@nforro nforro force-pushed the alternative-arches branch from 92e42b7 to efc0367 Compare December 10, 2024 18:39
@nforro nforro changed the title Try to fix the ppc64le container build issues Fix base image build Dec 10, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/24dc25ce5f344d648a86b0331fec6f6b

✔️ pre-commit SUCCESS in 1m 41s

@nforro nforro requested a review from mfocko December 10, 2024 20:25
mfocko
mfocko approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@mfocko mfocko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nforro nforro added the mergeit When set, zuul wil gate and merge the PR. label Dec 10, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/4f3cf1e30d144b788fb99ffd8b452bc4

✔️ pre-commit SUCCESS in 1m 41s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 52b4a80 into main Dec 10, 2024
4 checks passed
@nforro nforro deleted the alternative-arches branch December 10, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfocko mfocko mfocko approved these changes

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nforro @mfocko