Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receive and save OpenScanHub task finish event #2580

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Receive and save OpenScanHub task finish event #2580

merged 1 commit into from
Oct 22, 2024

Conversation

majamassarini
Copy link
Member

@majamassarini majamassarini commented Oct 11, 2024 •
edited
Loading

@majamassarini majamassarini changed the title Fix/packit-service/2543 Receive and save OpenScanHub task finish event Oct 11, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/083e9858cb9344e784254dd897b67dad

✔️ pre-commit SUCCESS in 2m 21s
❌ packit-service-tests FAILURE in 2m 38s

@majamassarini majamassarini force-pushed the fix/packit-service/2543 branch from 3ade7de to 56294f5 Compare October 11, 2024 13:18
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/5c6034d7012e4afb82acf5235f02258e

✔️ pre-commit SUCCESS in 2m 16s
✔️ packit-service-tests SUCCESS in 2m 31s

@majamassarini majamassarini force-pushed the fix/packit-service/2543 branch from 56294f5 to 8793f41 Compare October 14, 2024 12:15
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/9fd6d9ea4bc446beb986bacf48809f73

✔️ pre-commit SUCCESS in 2m 12s
✔️ packit-service-tests SUCCESS in 2m 47s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/f5b5ae55898e4cd7a1e32761c323f764

✔️ pre-commit SUCCESS in 2m 14s
❌ packit-service-tests FAILURE in 2m 33s

@siteshwar
Copy link
Contributor

Fixes #2543

Thank you for working on this! But it does not handle the case when the tasks may end up in failed, cancelled or interrupted state. So, the reporting is incomplete.

@majamassarini
Copy link
Member Author

Fixes #2543

Thank you for working on this! But it does not handle the case when the tasks may end up in failed, cancelled or interrupted state. So, the reporting is incomplete.

I am still working on it 🙂 I will push new commits soon (I hope).

@majamassarini majamassarini force-pushed the fix/packit-service/2543 branch from e55dede to dc073f1 Compare October 16, 2024 12:37
@majamassarini majamassarini marked this pull request as ready for review October 16, 2024 12:38
@majamassarini majamassarini requested review from mfocko and a team as code owners October 16, 2024 12:38
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/31111fd5fd2f47dca093c0b132c26b04

✔️ pre-commit SUCCESS in 4m 42s
❌ packit-service-tests FAILURE in 2m 56s

@majamassarini majamassarini force-pushed the fix/packit-service/2543 branch from dc073f1 to 7cbb194 Compare October 16, 2024 12:55
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/25bfc179da194df4931f8ebb0c7efffd

✔️ pre-commit SUCCESS in 2m 12s
✔️ packit-service-tests SUCCESS in 2m 24s

lbarcziova
lbarcziova reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job Maja, this will be great!

packit_service/models.py Outdated Show resolved Hide resolved
packit_service/models.py Show resolved Hide resolved
packit_service/worker/handlers/open_scan_hub.py Outdated Show resolved Hide resolved
packit_service/worker/handlers/open_scan_hub.py Outdated Show resolved Hide resolved
packit_service/worker/handlers/open_scan_hub.py Outdated Show resolved Hide resolved
packit_service/worker/handlers/open_scan_hub.py Outdated Show resolved Hide resolved
packit_service/worker/handlers/open_scan_hub.py Outdated Show resolved Hide resolved
packit_service/models.py Outdated Show resolved Hide resolved
packit_service/worker/handlers/open_scan_hub.py Outdated Show resolved Hide resolved
mfocko
mfocko reviewed Oct 16, 2024
View reviewed changes
packit_service/models.py Show resolved Hide resolved
packit_service/worker/handlers/open_scan_hub.py Outdated Show resolved Hide resolved
packit_service/worker/handlers/open_scan_hub.py Outdated Show resolved Hide resolved
@siteshwar siteshwar mentioned this pull request Oct 17, 2024
Closed
5 tasks
@majamassarini majamassarini force-pushed the fix/packit-service/2543 branch 2 times, most recently from 8f6003c to 2e9c2b6 Compare October 18, 2024 13:52
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/73282280d0a745c898228117fca2c01a

✔️ pre-commit SUCCESS in 2m 18s
❌ packit-service-tests FAILURE in 2m 40s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c2b2e3223db44e1788d73bfb9cfcb0d0

✔️ pre-commit SUCCESS in 2m 11s
❌ packit-service-tests FAILURE in 2m 29s

@majamassarini majamassarini force-pushed the fix/packit-service/2543 branch from 2e9c2b6 to 47e670a Compare October 18, 2024 13:56
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ecabe921b2cd46859038e0eb6fdfe5f3

✔️ pre-commit SUCCESS in 2m 19s
✔️ packit-service-tests SUCCESS in 2m 32s

This was referenced Oct 21, 2024
Merged
Merged
lbarcziova
lbarcziova approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small notes, otherwise LGTM, great job!

packit_service/worker/handlers/open_scan_hub.py Outdated Show resolved Hide resolved
packit_service/worker/handlers/open_scan_hub.py Show resolved Hide resolved
@majamassarini majamassarini force-pushed the fix/packit-service/2543 branch from 47e670a to a9b82c8 Compare October 22, 2024 08:43
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/00cb11d7f6074368a621bb2aacd63962

✔️ pre-commit SUCCESS in 2m 23s
❌ packit-service-tests FAILURE in 2m 43s

@majamassarini majamassarini force-pushed the fix/packit-service/2543 branch from a9b82c8 to 1659104 Compare October 22, 2024 08:47
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/590e193cf90942e897cff98540843490

✔️ pre-commit SUCCESS in 2m 21s
❌ packit-service-tests FAILURE in 2m 32s

@majamassarini
Handle Open Scan Hub events
0e81030 
task.started and task.finished
@majamassarini majamassarini force-pushed the fix/packit-service/2543 branch from 1659104 to 0e81030 Compare October 22, 2024 08:51
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/89f337c16beb4ef6be5d9fc63c22501d

✔️ pre-commit SUCCESS in 2m 25s
✔️ packit-service-tests SUCCESS in 2m 35s

softwarefactory-project-zuul bot added a commit to packit/packit-service-fedmsg that referenced this pull request Oct 22, 2024
@softwarefactory-project-zuul
Handle both started and finished OpenScanHub events (#114)
7e5c5c2 
Handle both started and finished OpenScanHub events

Merge before packit/packit-service#2580

Reviewed-by: Laura Barcziová
@majamassarini majamassarini added the mergeit When set, zuul wil gate and merge the PR. label Oct 22, 2024
softwarefactory-project-zuul bot added a commit to packit/deployment that referenced this pull request Oct 22, 2024
@softwarefactory-project-zuul
Allow both started and finished OpenScanHub msgs in queue (#607)
c3fcc95 
Allow both started and finished OpenScanHub msgs in queue

Related to packit/packit-service#2580

Reviewed-by: Laura Barcziová
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/2a5804ef75d348d3bc60943b2e41bfb3

✔️ pre-commit SUCCESS in 2m 29s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1c75a3e into packit:main Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes

@mfocko mfocko mfocko left review comments

@siteshwar siteshwar siteshwar left review comments

@kdudka kdudka kdudka left review comments

Assignees
No one assigned
Labels
mergeit When set, zuul wil gate and merge the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement OpenScanHub initial reporting
5 participants
@majamassarini @siteshwar @kdudka @mfocko @lbarcziova