Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to automate Fedora release onboarding #211

Closed

Conversation

lbarcziova
Copy link
Member

The script can generate the Packit config for dist-git repo and push it to rawhide or create a PR against rawhide with the config.

Fixes packit/packit-service#2301

The script can generate the Packit config for dist-git repo
and push it to rawhide or create a PR against rawhide with the config.

Fixes packit/packit-service#2301
@lbarcziova lbarcziova marked this pull request as draft January 31, 2024 09:44
Copy link
Member Author

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opening this PR for some early reviews and feedback

I was thinking about where to put this script (somewhere separately as in here, or create this as a Packit command) and am open for feedback/suggestions, because I see this could be used both by

  • maintainers who already used Packit and want to automatically generate the config for lot of packages (we could build upon this script with reading the input values from some JSON or similar)
  • for us (Packit devs) if we try to onboard some package to ease our work

Comment on lines +85 to +86
# TODO also make this as input parameter?
"dist_git_branches": ["fedora-all"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure here if we got this from input, whether these should be 3 separate arguments then (for each job), or one argument (pull_from_upstream and koji_build would use the input value directly and for bodhi-update we would compute the {targets-from-input} - {rawhide}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 parameter, probably just a single one

doing pull_from_upstream for all fedora releases can even violate guidelines so we should ideally advocate to update only in rawhide, as a safe measure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback, agreed!

Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the new script should be a subcommand of packit init, no question about that - I'd immediately run it on my packages that I'm lazy to onboard to packit :)

Comment on lines +85 to +86
# TODO also make this as input parameter?
"dist_git_branches": ["fedora-all"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 parameter, probably just a single one

doing pull_from_upstream for all fedora releases can even violate guidelines so we should ideally advocate to update only in rawhide, as a safe measure

@lbarcziova lbarcziova closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a script for automatic Packit config setup in dist-git
2 participants