Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove feature flag for v4 #1176

Merged
merged 1 commit into from
Feb 9, 2024
Merged

feat: remove feature flag for v4 #1176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ on:
env:
GIT_COMMIT: ${{ github.sha }}
GIT_REF: ${{ github.ref }}
ENABLE_FEATURE_V4: true
LOG_LEVEL: info

jobs:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ on:
env:
GIT_COMMIT: ${{ github.sha }}
GIT_REF: ${{ github.ref }}
ENABLE_FEATURE_V4: true
LOG_LEVEL: info

jobs:
Expand Down
6 changes: 0 additions & 6 deletions src/v4/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ export class PactV4 implements V4ConsumerPact {
private pact: ConsumerPact;

constructor(private opts: PactV4Options) {
if (!process.env.ENABLE_FEATURE_V4) {
throw Error(
"The v4 package is currently in beta and requires the 'ENABLE_FEATURE_V4' environment variable to be set"
);
}

this.setup();
this.pact.addMetadata('pact-js', 'version', pactPackageVersion);
}
Expand Down
Loading