Correção de erro fatal afetando outros produtos que fazem uso dessa biblioteca #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notei apenas agora que esta PR acaba sendo uma duplicata da #356, porém fornece as informações adicionais solicitadas nela.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descrição
Usamos o módulo de vocês para Magento, e notamos que estava disparando um erro fatal ao visualizarmos um pedido no admin da loja:
Essa PR visa corrigir isto.
Testes Realizados
Testamos a visualização antes e depois dessa correção numa instância do Magento 1.9.4.1 em ambos PHP 7.2 e 7.4
@sdoblinski @zitoloco @IvanMicai @jvrmaia @rsmelo