나무 1주차 #32
Merged
나무 1주차 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunhwa508
reviewed
Mar 19, 2022
| async function getParsedData(url: string, config: object) { | ||
| const response = await fetch(url, config); | ||
| return await response.json(); | ||
| } |
There was a problem hiding this comment.
오 parsed 부분와 config 를 이렇게 나누면 나중에 재활용하거나 활용하기 좋아 보이네용 굳굳 👍🏻
sunhwa508
reviewed
Mar 19, 2022
| return getParsedData(url, getConfig(METHOD.GET, data)); | ||
| } | ||
|
|
||
| export async function deleteAsync(url: string, data: object) { |
There was a problem hiding this comment.
await 키워드가 없는 함수에 async 가 붙어있네용?. ?
There was a problem hiding this comment.
핚 이런 날카로운 리뷰..^^ my (옛)pair답군요 감사합니당!!
InSeong-So
reviewed
Mar 20, 2022
Comment on lines
+18
to
+19
| headers: new Headers({ "content-type": "application/json" }), | ||
| body: data && JSON.stringify(data), |
Comment on lines
+1
to
+7
| export function setLocal(key: string, value: string) { | ||
| localStorage.setItem(key, value); | ||
| } | ||
|
|
||
| export function getLocal(key: string) { | ||
| return localStorage.getItem(key); | ||
| } |
There was a problem hiding this comment.
간단하게 래핑한 것 같네요🤭 key, value가 null/undefined 경우 에러/예외 처리를 추가하는 것도 좋아보여요👀
|
나무는 조금 늦게 시작해서 조금 더 열어둘게요!😁 |
감사합니다ㅠㅠ 이번주중에 마무리해볼게요!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔎 개요
나무] 구조 정리 #31
함수형으로 리팩토링을 진행하고 있습니다
typescript 변환이 쉬운 일부 코드는 ts로 변경했습니다
📝 진행상황
ing내 prettieringing🖼 스크린샷
💬 의견
바닐라가 낯설어서 리팩토링을 어떤식으로 할지 고민하느라 시간이 길어질 것 같아 일단 pr을 먼저 남깁니당!! 작업은 하는대로 업데이트하겠습니다
하다보니 폴더링 방식이나 저만의 구조 스타일이 없었다는게 느껴지네요 😇
각자의 힌트나 조언을 주시거나 리팩토링한 코드에서 의문점/개선방안을 날려주시면 감사드리겠습니다~~