Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-6373] feat: add new PartyRole ADMIN_EA_IO #689

Merged
merged 10 commits into from
Feb 5, 2025
Merged

[SELC-6373] feat: add new PartyRole ADMIN_EA_IO #689

merged 10 commits into from
Feb 5, 2025

Conversation

giulia-tremolada
Copy link
Collaborator

@giulia-tremolada giulia-tremolada commented Feb 3, 2025 •
edited
Loading

List of Changes

  • add new enum in PartyRole ADMIN_EA_IO
  • upgrade onboarding-sdk to version 0.6.7
  • create new versione v2 of the following exposed APIs:
    • POST /v2/onboarding/completion
    • GET /v2/onboarding/institutionOnboardings
    • POST /v2/onboarding/pa/completion
    • POST /v2/onboarding/pg/completion
    • POST /v2/onboarding/psp/completion
  • mapping v1 response to avoid breaking changes in exposed APIs
  • add and modify unit tests

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added functions Changes are related to functions onboarding-ms libs labels Feb 3, 2025
@giulia-tremolada
add OnboardingV2ControllerTest
e921710
@giulia-tremolada
add OnboardingMapper unit test
c4905bb
@giulia-tremolada
modify OnboardingController tests to cover mapper coverage
55d2f8e
@giulia-tremolada
Merge branch 'main' into feature/SELC-6373
4a53c90 
# Conflicts:
#	apps/onboarding-ms/src/main/java/it/pagopa/selfcare/onboarding/service/OnboardingServiceDefault.java
#	apps/onboarding-ms/src/test/java/it/pagopa/selfcare/onboarding/service/OnboardingServiceDefaultTest.java
@giulia-tremolada
variables names refactor
97008a0
@giulia-tremolada
remove unused argument captor
87068e4
@giulia-tremolada giulia-tremolada marked this pull request as ready for review February 4, 2025 15:20
@giulia-tremolada giulia-tremolada requested a review from a team as a code owner February 4, 2025 15:20
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@giulia-tremolada giulia-tremolada merged commit 1f6cf8f into main Feb 5, 2025
11 of 13 checks passed
@giulia-tremolada giulia-tremolada deleted the feature/SELC-6373 branch February 5, 2025 15:39
giulia-tremolada added a commit that referenced this pull request Feb 6, 2025
@giulia-tremolada
Revert "[SELC-6373] feat: add new PartyRole ADMIN_EA_IO (#689)"
68ae019 
This reverts commit 1f6cf8f.
@giulia-tremolada giulia-tremolada mentioned this pull request Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleDore AleDore AleDore approved these changes

Assignees
No one assigned
Labels
functions Changes are related to functions libs onboarding-ms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giulia-tremolada @AleDore