Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-6463] feat: added check on product parent onboarding #699

Merged
merged 1 commit into from
Feb 17, 2025
Merged

[SELC-6463] feat: added check on product parent onboarding #699

merged 1 commit into from
Feb 17, 2025

Conversation

pierpaolodidato89
Copy link
Collaborator

@pierpaolodidato89 pierpaolodidato89 commented Feb 17, 2025 •
edited
Loading

List of Changes

  • Added verifiy onboarding for parent product
  • Added prod-dashboard-psp as allowed products to onboard
  • Added unit tests for different scenarios

Motivation and Context

In case of missed onboarding for parent product, an invalid request exception is thrown in order to block the onboarding for child product

How Has This Been Tested?

I have started the ms locally and tested the different scenarios

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pierpaolodidato89 pierpaolodidato89 marked this pull request as ready for review February 17, 2025 12:25
@pierpaolodidato89 pierpaolodidato89 requested review from a team as code owners February 17, 2025 12:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pierpaolodidato89 pierpaolodidato89 merged commit 3c58143 into main Feb 17, 2025
18 checks passed
@pierpaolodidato89 pierpaolodidato89 deleted the feature/SELC-6463 branch February 17, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianmarcoplutino gianmarcoplutino gianmarcoplutino approved these changes

Assignees
No one assigned
Labels
onboarding-ms ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierpaolodidato89 @gianmarcoplutino