all done #113
Open
all done #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djlax805
reviewed
May 10, 2019
| @@ -1,12 +1,23 @@ | |||
| def get_letter_grade(integer) | |||
|
|
|||
| #Put your code here! | |||
|
|
|||
| if (90..100).include?(integer) | |||
There was a problem hiding this comment.
Interesting solution to use a range and include?! You could also use Ruby's comparable methods since they are integers.
djlax805
reviewed
May 10, 2019
| end | ||
|
|
||
| def shortest_string(array) | ||
|
|
||
| #Put your code here! | ||
| return nil if array.empty? |
There was a problem hiding this comment.
I don't think this line is necessary as min_by will return nil by default if the array is empty. Nice use of the & method syntax though 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.