warnings: close logconfig_json after parse

gunicorn/glogging.py

@@ -242,7 +242,8 @@ def setup(self, cfg):
             config = CONFIG_DEFAULTS.copy()
             if os.path.exists(cfg.logconfig_json):
                 try:
-                    config_json = json.load(open(cfg.logconfig_json))
+                    with open(cfg.logconfig_json) as f:
+                        config_json = json.load(f)
                     config.update(config_json)
                     dictConfig(config)
                 except (

tests/test_logger.py

@@ -1,10 +1,26 @@
 import datetime
+import tempfile
 from types import SimpleNamespace
 
 import pytest
 
 from gunicorn.config import Config
 from gunicorn.glogging import Logger
+from unittest import mock
+
+
+@mock.patch('json.load')
+def test_json_loaded(load):
+    with tempfile.NamedTemporaryFile() as f:
+        f.write("{}".encode())
+        f.flush()
+
+        cfg = Config()
+        cfg.set("logconfig_json", f.name)
+        logger = Logger(cfg)
+        logger.debug("foo")
+
+        load.assert_called_once()
 
 
 def test_atoms_defaults():