Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new icon - subtract join #7132

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

annawhittakermuratt
Copy link

@annawhittakermuratt annawhittakermuratt commented Dec 18, 2024

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

adds the subtract join icon

Reviewers should focus on:

Screenshot

Screenshot 2024-12-18 at 12 12 23

@changelog-app
Copy link

changelog-app bot commented Dec 18, 2024

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

feat: new icon - subtract join

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

feat: new icon - subtract join

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ryannono
Copy link
Contributor

ryannono commented Dec 18, 2024

I would add some direction to the icon name, ex. Join: Subtract right

Additionally @ggdouglas will comment more on this but you can have this icon export in a single path if in figma you:

  1. Select all layers
  2. Union the layers
  3. Select the newly created "Union" parent layer
  4. Outline stroke of this layer
  5. Flatten the layer
  6. Export

Then you should get something like (granted you'll have to remove fill and size props on the svg):

<svg viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg"> <path fill-rule="evenodd" d="M6.0056 3.10116C4...."/> </svg>

resources/icons/16px/subtract-join.svg Outdated Show resolved Hide resolved
resources/icons/20px/subtract-join.svg Outdated Show resolved Hide resolved
packages/icons/icons.json Outdated Show resolved Hide resolved
@svc-palantir-github
Copy link

rename icons

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

ggdouglas
ggdouglas previously approved these changes Jan 6, 2025
@policy-bot policy-bot bot dismissed ggdouglas’s stale review January 7, 2025 16:37

Invalidated by push of 5e841b0

@svc-palantir-github
Copy link

make into single paths

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

ggdouglas
ggdouglas previously approved these changes Jan 7, 2025
@policy-bot policy-bot bot dismissed ggdouglas’s stale review January 8, 2025 10:54

Invalidated by push of 18c3b24

@svc-palantir-github
Copy link

Add generated changelog entries

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@annawhittakermuratt annawhittakermuratt enabled auto-merge (squash) January 8, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants