Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code snippet in RadioCard documentation #7134

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Deuteu
Copy link
Contributor

@Deuteu Deuteu commented Dec 20, 2024

To be coherent with actual code

And also in my experience currentValue was null

To be coherent with actual code
@changelog-app
Copy link

changelog-app bot commented Dec 20, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fix code snippet in RadioCard documentation

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Add generated changelog entries

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas
Copy link
Contributor

And also in my experience currentValue was null

Can you elaborate on where you are seeing currentValue as null? From my understanding, event.target and currentTarget should be equivalent in this particular case (example here).

This is because RadioGroup internally applies the onChange event handler directly to each of its children:

onChange: this.props.onChange,

Therefore, event.currentTarget seems relevant since it references the element to which the event handler has been attached.

Is there an advantage towards suggesting this alternative approach of casting as HTMLInputElement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants