Skip to content

Commit

Permalink
Fix comments re: jackson coercion of scalars (#978)
Browse files Browse the repository at this point in the history
## Before this PR

Ignore file was mentioning the wrong jackson flag - we already use ALLOW_COERCION_OF_SCALARS, but it doesn't work with afterburner. See FasterXML/jackson-modules-base#70

## After this PR

Fixed comments to more accurately describe the ignores that will be fixed by jackson 2.9.9
  • Loading branch information
dansanduleac authored and bulldozer-bot[bot] committed Mar 12, 2019
1 parent 26995e8 commit e2f4098
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ client:
autoDeserialize:

receiveBooleanExample:
- '{"value":0}' # jackson is casting 0 -> false and 1 -> true... MapperFeature.ALLOW_COERCION_OF_SCALARS);) in 2.9 will save us
- '{"value":"true"}' # jackson is casting 0 -> false and 1 -> true... MapperFeature.ALLOW_COERCION_OF_SCALARS);) in 2.9 will save us
- '{"value":0}' # jackson is casting 0 -> false and 1 -> true... 2.9.9 will save us - https://github.com/FasterXML/jackson-modules-base/pull/70
- '{"value":"true"}' # jackson is casting 0 -> false and 1 -> true... 2.9.9 will save us - https://github.com/FasterXML/jackson-modules-base/pull/70

receiveStringExample:
- '{"value":8}' # jackson coerces things to other types
receiveIntegerExample:
- '{"value":"12"}' # jackson coerces things to other types
- '{"value":"12"}' # jackson coerces things to other types... 2.9.9 will save us - https://github.com/FasterXML/jackson-modules-base/pull/70

receiveSetStringExample:
- '{"value":["a","a"]}' # client turns this into a set of ["a"] without error
Expand Down

0 comments on commit e2f4098

Please sign in to comment.