[don't merge without broader conversation] Fix scalar coerscion tests by disabling afterburner #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...if we disable afterburner. We can fix the afterburner bug, however I've been unable to produce a benchmark showing clear wins with the afterburner module.
|
Well, that's one way to do it! |
|
Oh fun, would you mind adding that link to the ignore line? |
|
Closing given FasterXML/jackson-modules-base#70 |
| receiveBooleanExample: | ||
| - '{"value":0}' # jackson is casting 0 -> false and 1 -> true... MapperFeature.ALLOW_COERCION_OF_SCALARS);) in 2.9 will save us | ||
| - '{"value":"true"}' # jackson is casting 0 -> false and 1 -> true... MapperFeature.ALLOW_COERCION_OF_SCALARS);) in 2.9 will save us | ||
|
|
||
| receiveStringExample: | ||
| - '{"value":8}' # jackson coerces things to other types |
There was a problem hiding this comment.
it's interesting that this is still allowed even with ALLOW_COERCION_OF_SCALARS on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapperFeature.ALLOW_COERCION_OF_SCALARS will save us
...if we disable afterburner. We can fix the afterburner bug,
however I've been unable to produce a benchmark showing clear
wins using the afterburner module.