Code

WIP: Fix phpstan issues#226

Code

Closed

agentrickard wants to merge 53 commits intomainpalantirnet/drupal-rector:mainfrom stan-failspalantirnet/drupal-rector:stan-failsCopy head branch name to clipboard

+557-192

Commits

Commits on Jul 7, 2023

• Merge in changes from bbrala:feature/remove-nodetoaddcolector

  agentrickard

  committed
  6e0e8bd

  Copy full SHA for 6e0e8bd

• Simple fix for PARENT_NODE

  agentrickard

  committed
  d6cfaea

  Copy full SHA for d6cfaea

• Simple fixes for PARENT_NODE

  agentrickard

  committed
  adcbe7d

  Copy full SHA for adcbe7d

• Update phpstan.neon with note

  agentrickard

  committed
  4c86b3a

  Copy full SHA for 4c86b3a

• Fix typo

  agentrickard

  committed
  e746161

  Copy full SHA for e746161

• Fix ussage of NEXT_NODE

  agentrickard

  committed
  48d72b1

  Copy full SHA for 48d72b1

• Merge branch 'main' into stan-fails

  agentrickard

  authored
  e51bdb0

  Copy full SHA for e51bdb0

Commits on Jul 8, 2023

• Fix find parent by type by cheating the method into a trait

  bbrala

  committed
  b2b80f5

  Copy full SHA for b2b80f5

• Use the findParentTypeTrait to fix DrupalSetMessageRector

  bbrala

  committed
  a9dd56d

  Copy full SHA for a9dd56d

Commits on Jul 10, 2023

• Push potential changes for review -- even though failing

  agentrickard

  committed
  a7d4101

  Copy full SHA for a7d4101

• Merge branch 'stan-fails' into fix/find-parent-by-type

  agentrickard

  authored
  e226388

  Copy full SHA for e226388

• Merge pull request #227 from bbrala/fix/find-parent-by-type

  Show description for 3372372
  agentrickard

  authored
  3372372

  Copy full SHA for 3372372

• Update phpunit config

  agentrickard

  committed
  5b7e71d

  Copy full SHA for 5b7e71d

Commits on Jul 12, 2023

• listen for expression if needing to add comment

  mglaman

  committed
  75ae409

  Copy full SHA for 75ae409

• Merge pull request #230 from mglaman/parent-traverse-fix

  Show description for d2c3201
  agentrickard

  authored
  d2c3201

  Copy full SHA for d2c3201

• Fixes phpstan errors

  agentrickard

  committed
  40f28ae

  Copy full SHA for 40f28ae

Commits on Jul 17, 2023

• Add a CommentingVisitor

  Show description for 0ff8a5c
  bbrala

  committed
  0ff8a5c

  Copy full SHA for 0ff8a5c

• Set correct attribute

  bbrala

  committed
  aa97d97

  Copy full SHA for aa97d97

• Revert "listen for expression if needing to add comment"

  Show description for d167b87
  bbrala

  committed
  d167b87

  Copy full SHA for d167b87

• ExtensionPathBase needs to use the expression node to be able to add comments.

  bbrala

  committed
  5d22722

  Copy full SHA for 5d22722

• Be more specific

  bbrala

  committed
  656f8bd

  Copy full SHA for 656f8bd

Commits on Jul 18, 2023

• HAve to update to use interface also in functional tests that do not use dev dependency

  bbrala

  committed
  35cf34d

  Copy full SHA for 35cf34d

• Refactor DBBase to use expression

  bbrala

  committed
  4aa9cf5

  Copy full SHA for 4aa9cf5

• Some small fixes to green last few unit tests

  bbrala

  committed
  bf88199

  Copy full SHA for bf88199

• refactor LinkGeneratorTraitLRector to expression

  bbrala

  committed
  73f79a9

  Copy full SHA for 73f79a9

• refactor LinkGeneratorTraitLRector to expression

  bbrala

  committed
  9e4ae7b

  Copy full SHA for 9e4ae7b

• DBBase fix for assigned expressions

  bbrala

  committed
  905de83

  Copy full SHA for 905de83

• DBBase fix logic

  bbrala

  committed
  6e03a17

  Copy full SHA for 6e03a17

• refaactor EntityInterfaceLinkRector to use stmt

  bbrala

  committed
  ab18c67

  Copy full SHA for ab18c67

• Refactor EntityInterfaceLinkRector to use stmt and also consider Assign calls

  bbrala

  committed
  b689652

  Copy full SHA for b689652

• Refactor EntityInterfaceLinkRector to use stmt and also consider Assign calls

  bbrala

  committed
  1586f26

  Copy full SHA for 1586f26

• Update rector.php whitespace

  bbrala

  committed
  ab07065

  Copy full SHA for ab07065

• Refactor DBBase to allow for chained methods

  bbrala

  committed
  9a5c27a

  Copy full SHA for 9a5c27a

• EntityLoadBase to stmt is too hard

  bbrala

  committed
  331bc38

  Copy full SHA for 331bc38

• EntityLoadBase to stmt is too hard, updating expected result

  bbrala

  committed
  0c4acd2

  Copy full SHA for 0c4acd2

• EntityLoadBase to stmt is too hard, updating expected result

  bbrala

  committed
  0813381

  Copy full SHA for 0813381

Commits on Jul 19, 2023

• Commenting visitor is a dead end. You cannot change nodes above where you are working in the rector. Therefor, a comment should always be passed an Expression.

  bbrala

  committed
  4b086b0

  Copy full SHA for 4b086b0

• Fix commenting again

  bbrala

  committed
  1b60db5

  Copy full SHA for 1b60db5

• Refactor MethodToMethodBase to Stmt\Expression

  bbrala

  committed
  9325773

  Copy full SHA for 9325773

Commits on Jul 20, 2023

• Refactor EntityManagerRector to Stmt\Expression also add very usefull methods for working with assignements

  bbrala

  committed
  e589006

  Copy full SHA for e589006

• Fix slight error in replaceInstanceByNameInAssign mthod

  bbrala

  committed
  56065a3

  Copy full SHA for 56065a3

• Revert "EntityLoadBase to stmt is too hard, updating expected result"

  Show description for 611d0f3
  bbrala

  committed
  611d0f3

  Copy full SHA for 611d0f3

• Revert "EntityLoadBase to stmt is too hard, updating expected result"

  Show description for 1614b4c
  bbrala

  committed
  1614b4c

  Copy full SHA for 1614b4c

• Revert "EntityLoadBase to stmt is too hard"

  Show description for 2d01c08
  bbrala

  committed
  2d01c08

  Copy full SHA for 2d01c08

• Refactor EntityLoadBase to use Stmt

  bbrala

  committed
  e956dd3

  Copy full SHA for e956dd3

• Remove unused method from AddCommentTrait.php

  bbrala

  committed
  75da8fb

  Copy full SHA for 75da8fb

• Remove unused use statement

  bbrala

  committed
  2046e7e

  Copy full SHA for 2046e7e

• Remove unused use statement

  bbrala

  committed
  d96f5cb

  Copy full SHA for d96f5cb

• remove debug echo

  bbrala

  committed
  7d5432a

  Copy full SHA for 7d5432a

Commits on Aug 2, 2023

• Update rector.php for one less line change and getrigger for rector update

  bbrala

  authored
  80dec88

  Copy full SHA for 80dec88

Commits on Aug 7, 2023

• Update ddev action see https://github.com/jonaseberle/github-action-setup-ddev

  Show description for 39efd19
  bbrala

  committed
  39efd19

  Copy full SHA for 39efd19

• Merge pull request #232 from bbrala/fix/do-comments-by-visitor

  Show description for f7d1bcd
  agentrickard

  authored
  f7d1bcd

  Copy full SHA for f7d1bcd

Commits on Aug 16, 2023

• Merge branch 'main' into stan-fails

  agentrickard

  authored
  0d64945

  Copy full SHA for 0d64945