Skip to content

Commit

Permalink
CompatHelper: bump compat for BSplineKit to 0.18, (keep existing comp…
Browse files Browse the repository at this point in the history
…at) (#104)

* CompatHelper: bump compat for BSplineKit to 0.18, (keep existing compat)

* Update Project.toml

* explicit import of fit

---------

Co-authored-by: CompatHelper Julia <[email protected]>
Co-authored-by: Phillip Alday <[email protected]>
Co-authored-by: Phillip Alday <[email protected]>
  • Loading branch information
4 people authored Feb 9, 2025
1 parent f863a51 commit 8dfeb9c
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 278 deletions.
27 changes: 13 additions & 14 deletions .github/workflows/style.yml
Original file line number Diff line number Diff line change
@@ -1,35 +1,34 @@
name: Style-Enforcer
on:
push:
branches:
- 'main'
tags: '*'
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
# note: keep in sync with `format/run.jl`
paths-ignore:
- 'README.md'
- '.gitignore'
jobs:
format-check:
name: Style Enforcement
# Run on push's or non-draft PRs
if: (github.event_name == 'push') || (github.event.pull_request.draft == false)
runs-on: ubuntu-latest
strategy:
matrix:
julia-version: [1.9]
julia-version: [min]
steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@latest
with:
version: ${{ matrix.julia-version }}
- uses: actions/checkout@v4
- name: Instantiate `format` environment and format
- name: Install JuliaFormatter
shell: julia --project=@format --color=yes {0}
run: |
using Pkg
Pkg.add(PackageSpec(; name="JuliaFormatter", version="1"))
- name: Check formatting
shell: julia --project=@format --color=yes {0}
run: |
julia --project=format -e 'using Pkg; Pkg.instantiate()'
julia --project=format 'format/run.jl'
using JuliaFormatter
format(".", YASStyle(); verbose=true) || exit(1)
# Add formatting suggestions to non-draft PRs even if "Check formatting" fails
- uses: reviewdog/action-suggester@v1
if: github.event_name == 'pull_request'
if: ${{ !cancelled() && github.event.pull_request.draft == false }}
with:
tool_name: JuliaFormatter
fail_on_error: true
6 changes: 3 additions & 3 deletions Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "MixedModelsMakie"
uuid = "b12ae82c-6730-437f-aff9-d2c38332a376"
authors = ["Phillip Alday <[email protected]>", "Douglas Bates <[email protected]>", "contributors"]
version = "0.4.5"
version = "0.4.6"

[deps]
BSplineKit = "093aae92-e908-43d7-9660-e50ee39d5a0a"
Expand All @@ -18,7 +18,7 @@ StatsBase = "2913bbd2-ae8a-5f71-8c99-4fb6c76f3a91"

[compat]
Aqua = "0.5, 0.6"
BSplineKit = "0.15, 0.16, 0.17"
BSplineKit = "0.15, 0.16, 0.17, 0.18"
CairoMakie = "0.11, 0.12, 0.13"
DataFrames = "1"
Distributions = "0.25"
Expand All @@ -32,7 +32,7 @@ Statistics = "1"
StatsBase = "0.33, 0.34"
Suppressor = "0.2"
TestSetExtensions = "3"
julia = "1.9"
julia = "1.10"

[extras]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
Expand Down
239 changes: 0 additions & 239 deletions format/Manifest.toml

This file was deleted.

2 changes: 0 additions & 2 deletions format/Project.toml

This file was deleted.

20 changes: 0 additions & 20 deletions format/run.jl

This file was deleted.

3 changes: 3 additions & 0 deletions src/MixedModelsMakie.jl
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ using Printf
using SpecialFunctions
using StatsBase

# why, BSplineKit, do you export fit???
using MixedModels: fit

export RanefInfo,
caterpillar,
caterpillar!,
Expand Down

2 comments on commit 8dfeb9c

@palday
Copy link
Owner

@palday palday commented on 8dfeb9c Feb 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/124617

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.4.6 -m "<description of version>" 8dfeb9c263bc1b9b247d8089fd5ee46e1aff9294
git push origin v0.4.6

Please sign in to comment.