Cached queries #59
Merged
Cached queries #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagalago
force-pushed
the
cached_queries
branch
3 times, most recently
from
b1a92e2 to
17ebefe
Compare
gagalago
force-pushed
the
cached_queries
branch
from
17ebefe to
5e13119
Compare
|
Looks good. Thanks! |
|
Released in 0.7.2 |
|
thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
sometimes Rails cache queries, so even if they are performed many times, in practice, they go only once to the database other stay in the Rails process. In that case, we can ignore to count them as they are close to free.
we can configure the cache of queries that way in rails: https://guides.rubyonrails.org/configuring.html#configuring-query-cache
What changes did you make? (overview)
I added an option to ignore cached queries (false by default).
corresponding code in rails that generate these events:
ActiveRecord::QueryCacheIs there anything you'd like reviewers to focus on?
Naming of variables is always hard.
Checklist