chore(repo): set stricter type checking

apps/extension/package.json

@@ -4,7 +4,7 @@
   "type": "module",
   "scripts": {
     "dev": "bunx --bun vite",
-    "build": "tsc --noEmit && bun run build:rpc && bunx --bun vite build",
+    "build": "bunx --bun tsc --noEmit && bun run build:rpc && bunx --bun vite build",
     "build:rpc": "bunx --bun tsup",
     "build:firefox": "web-ext build --source-dir=dist",
     "build:safari": "xcrun safari-web-extension-converter dist --app-name Pallad --bundle-identifier co.pallad.app --swift --no-prompt --force --macos-only --no-open",

packages/common/package.json

@@ -17,7 +17,7 @@
     }
   },
   "scripts": {
-    "build": "bunx --bun tsup src/index.ts --dts --format esm --silent",
+    "build": "bunx --bun tsc --noEmit && bunx --bun tsup src/index.ts --dts --format esm --silent",
     "cleanup": "bunx --bun rimraf node_modules dist .turbo"
   }
 }

packages/features/package.json

@@ -24,7 +24,7 @@
     }
   },
   "scripts": {
-    "build": "bunx --bun tsup",
+    "build": "bunx --bun tsc --noEmit && bunx --bun tsup",
     "dev": "bunx --bun tsup --watch",
     "test:unit": "echo 'not yet'",
     "story:dev": "VITE_APP_LADLE=true bunx --bun ladle serve",

packages/features/src/common/hooks/use-transactions.ts

@@ -1,3 +1,4 @@
+import type { Mina } from "@palladxyz/mina-core"
 import { getPublicKey, useVault } from "@palladxyz/vault"
 import useSWR from "swr"
 
@@ -8,6 +9,7 @@ export const useTransactions = () => {
   const networkId = useVault((state) => state.currentNetworkId)
   return useSWR(
     publicKey ? [publicKey, "transactions", networkId] : null,
-    () => getTransactions(networkId, publicKey, "MINA"), // TODO: remove hardcoded 'MINA'
+    () =>
+      getTransactions(networkId, publicKey, "MINA") as Mina.TransactionBody[], // TODO: remove hardcoded 'MINA'
   )
 }

packages/features/src/common/lib/validation.ts

@@ -1,4 +1,3 @@
-import { utf8ToBytes } from "@noble/hashes/utils"
 import { z } from "zod"
 
 export const passwordSchema = z

packages/features/src/components/autocomplete.tsx

@@ -7,7 +7,6 @@ import {
 import clsx from "clsx"
 import { matchSorter } from "match-sorter"
 import { take } from "rambda"
-import React from "react"
 import type { ClipboardEventHandler } from "react"
 import type { UseFormRegisterReturn } from "react-hook-form"
 

packages/features/src/components/hash-dropdown.tsx

@@ -21,7 +21,7 @@ export const HashDropdown = ({ hash, className }: HashDropdownProps) => {
     toast.success("Hash Copied")
   }
   const openInExplorer = () => {
-    const url = currentNetworkInfo.explorer.transactionUrl.replace(
+    const url = currentNetworkInfo?.explorer.transactionUrl.replace(
       "{hash}",
       hash,
     )

packages/features/src/components/wizard-layout.tsx

@@ -1,5 +1,4 @@
 import clsx from "clsx"
-import { ArrowLeftIcon } from "lucide-react"
 import { useNavigate } from "react-router-dom"
 import { MenuBar } from "./menu-bar"
 

packages/features/src/lock/views/unlock-wallet.tsx

@@ -1,7 +1,6 @@
 import type { UseFormReturn } from "react-hook-form"
 
 import { FormError } from "@/components/form-error"
-import { RestartWalletAlert } from "@/components/restart-wallet-alert"
 import { WizardLayout } from "@/components/wizard-layout"
 import clsx from "clsx"
 import { EyeIcon, EyeOffIcon } from "lucide-react"
@@ -20,8 +19,6 @@ type UnlockWalletViewProps = {
 }
 
 export const UnlockWalletView = ({
-  restartAlertVisible,
-  setRestartAlertVisible,
   form,
   onSubmit,
   showPassword,
@@ -42,10 +39,6 @@ export const UnlockWalletView = ({
       </button>
     }
   >
-    <RestartWalletAlert
-      open={restartAlertVisible}
-      setOpen={setRestartAlertVisible}
-    />
     <div className="w-full flex flex-col flex-1 items-center gap-12">
       <form
         onSubmit={form.handleSubmit(onSubmit)}

packages/features/src/onboarding/routes/restore-wallet.tsx

@@ -1,4 +1,3 @@
-import React from "react"
 import { useNavigate } from "react-router-dom"
 import { shallow } from "zustand/shallow"
 

packages/features/src/receive/index.stories.tsx

@@ -1,12 +1,12 @@
 import { action } from "@ladle/react"
 import type { StoryDefault } from "@ladle/react"
-import React from "react"
 
 import { ReceiveView } from "./views/receive"
 
 export const Receive = () => {
   return (
     <ReceiveView
+      walletName="Test"
       publicKey="B62qizYjLtUebFFQuAnPjpLrUdWx4rLnptvzbVdNpY6EXff2U68Ljf5"
       onCopyWalletAddress={action("Address Copied")}
       onGoBack={action("Go Back")}

packages/features/src/send/index.stories.tsx

@@ -14,7 +14,7 @@ export const Send: Story<{ advanced: boolean }> = ({ advanced }) => (
     fiatPrice={1.5}
     advanced={advanced}
     setAdvanced={action("Set Advanced")}
-    currentNetwork="Devnet"
+    networkId="mina:devnet"
   />
 )
 

packages/features/src/settings/index.stories.tsx

@@ -15,12 +15,17 @@ export const Settings = () => (
   <SettingsView
     onCloseClicked={action("Go Back")}
     onDonateClicked={action("Donate Clicked")}
+    onLogOut={action("Log Out")}
   />
 )
 
 export const About = () => <AboutView onCloseClicked={action("Go Back")} />
 export const AuthorizedZkApps = () => (
-  <AuthorizedZkAppsView onCloseClicked={action("Go Back")} />
+  <AuthorizedZkAppsView
+    onCloseClicked={action("Go Back")}
+    apps={[]}
+    handleDeleteApp={action("Delete App")}
+  />
 )
 
 export const Support = () => <SupportView onCloseClicked={action("Go Back")} />
@@ -39,7 +44,13 @@ export const Language = () => (
   <LanguageView onCloseClicked={action("Go Back")} />
 )
 
-export const Privacy = () => <PrivacyView onCloseClicked={action("Go Back")} />
+export const Privacy = () => (
+  <PrivacyView
+    onCloseClicked={action("Go Back")}
+    setShareData={action("Share Data")}
+    shareData={true}
+  />
+)
 
 export default {
   title: "Settings",

packages/features/src/staking/index.stories.tsx

@@ -9,7 +9,9 @@ export const Overview: Story<{ stakeDelegated: boolean }> = ({
 }) => (
   <StakingOverviewView
     stakeDelegated={stakeDelegated}
-    onChangePool={action("Change Pool")}
+    account={null as never}
+    rewards={[]}
+    stats={{ avgReward: 0, totalReward: 0, lastReward: 0 }}
   />
 )
 

packages/features/src/staking/routes/staking-overview.tsx

@@ -17,16 +17,34 @@ export const StakingOverviewRoute = () => {
     .filter((tx) => tx.from !== accountInfo.MINA.publicKey)
   const rewards = Array(6)
     .fill({ amount: 0 })
-    .map((_, i) => ({ amount: rewardsTransactions?.[i]?.amount ?? 0 }))
+    .map((_, i) => ({
+      amount:
+        Number.parseFloat(
+          rewardsTransactions?.[i]?.amount?.toString() ?? "0",
+        ) ?? 0,
+    }))
   return (
     <StakingOverviewView
       account={account}
       rewards={rewards}
       stakeDelegated={account.stakeDelegated}
       stats={{
-        lastReward: rewardsTransactions[0]?.amount ?? 0,
-        avgReward: mean(rewardsTransactions.map((tx) => tx?.amount)) || 0,
-        totalReward: sum(rewardsTransactions.map((tx) => tx?.amount)),
+        lastReward:
+          Number.parseFloat(
+            rewardsTransactions?.[0]?.amount?.toString() ?? "0",
+          ) ?? 0,
+        avgReward:
+          mean(
+            rewardsTransactions?.map((tx) =>
+              Number.parseFloat(tx?.amount?.toString() ?? "0"),
+            ) ?? [],
+          ) ?? 0,
+        totalReward:
+          sum(
+            rewardsTransactions?.map((tx) =>
+              Number.parseFloat(tx?.amount?.toString() ?? "0"),
+            ) ?? [],
+          ) ?? 0,
       }}
     />
   )