OSI: fix null ptr dereference when current thread is NULL

panda-re · Dec 28, 2023 · 1571528 · 1571528
1 parent ff14601
commit 1571528
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/panda/plugins/osi/os_intro.c b/panda/plugins/osi/os_intro.c
@@ -180,9 +180,16 @@ OsiThread *get_current_thread(CPUState *cpu) {
     if((cachedInstructionCount != 0) &&
             (cachedInstructionCount == cpu->rr_guest_instr_count)) {
         thread=(OsiThread *) g_malloc(sizeof(*thread));
+        if (thread == NULL) {
+            return NULL;
+        }
         memcpy(thread, &cachedThread, sizeof(*thread));
     } else {
         PPP_RUN_CB(on_get_current_thread, cpu, &thread);
+        if (thread == NULL) {
+            // Returns NULL if OSI can't find the current thread
+            return NULL;
+        }
         cachedInstructionCount = cpu->rr_guest_instr_count;
         memcpy(&cachedThread, thread, sizeof(cachedThread));
     }