TST(str dtype): Resolve xfail in test_value_counts.py

pandas-dev · Jan 12, 2025 · 29ee20e · 29ee20e
1 parent a81d52f
commit 29ee20e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/pandas/tests/frame/methods/test_to_dict_of_blocks.py b/pandas/tests/frame/methods/test_to_dict_of_blocks.py
@@ -39,8 +39,9 @@ def test_to_dict_of_blocks_item_cache():
 
     df._to_dict_of_blocks()
 
+    values = ser.values
     with pytest.raises(ValueError, match="read-only"):
-        ser.values[0] = "foo"
+        values[0] = "foo"
 
 
 def test_set_change_dtype_slice():

diff --git a/pandas/tests/frame/methods/test_value_counts.py b/pandas/tests/frame/methods/test_value_counts.py
@@ -1,10 +1,6 @@
 import numpy as np
 import pytest
 
-from pandas._config import using_string_dtype
-
-from pandas.compat import HAS_PYARROW
-
 import pandas as pd
 import pandas._testing as tm
 
@@ -136,9 +132,6 @@ def test_data_frame_value_counts_dropna_true(nulls_fixture):
     tm.assert_series_equal(result, expected)
 
 
-@pytest.mark.xfail(
-    using_string_dtype() and not HAS_PYARROW, reason="TODO(infer_string)", strict=False
-)
 def test_data_frame_value_counts_dropna_false(nulls_fixture):
     # GH 41334
     df = pd.DataFrame(