Fix group_sum NaN comparison warnings

pandas-dev · Jan 21, 2025 · 64f2798 · 64f2798
1 parent b983366
commit 64f2798
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/pandas/_libs/groupby.pyx b/pandas/_libs/groupby.pyx
@@ -744,21 +744,17 @@ def group_sum(
             for j in range(K):
                 val = values[i, j]
 
-                if not skipna and (
-                    (uses_mask and result_mask[lab, j]) or
-                    (is_datetimelike and sumx[lab, j] == NPY_NAT) or
-                    _treat_as_na(sumx[lab, j], False)
-                ):
-                    # If sum is already NA, don't add to it. This is important for
-                    # datetimelikebecause adding a value to NPY_NAT may not result
-                    # in a NPY_NAT
-                    continue
-
                 if uses_mask:
                     isna_entry = mask[i, j]
                 else:
                     isna_entry = _treat_as_na(val, is_datetimelike)
 
+                if not skipna and isna_entry:
+                    # If sum is already NA, don't add to it. This is important for
+                    # datetimelikebecause adding a value to NPY_NAT may not result
+                    # in a NPY_NAT
+                    continue
+
                 if not isna_entry:
                     nobs[lab, j] += 1