Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Support skipna parameter in GroupBy mean and sum #60741

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

snitish
Copy link
Contributor

@snitish snitish commented Jan 20, 2025

This PR would only partially close #15675. There are other reductions that still need to support skipna. Once approved, I plan to address the remaining.

@snitish snitish marked this pull request as draft January 20, 2025 20:42
@snitish snitish marked this pull request as ready for review January 21, 2025 01:13
@mroeschke mroeschke added this to the 3.0 milestone Jan 21, 2025
@mroeschke mroeschke merged commit 42bf375 into pandas-dev:main Jan 21, 2025
50 of 55 checks passed
@mroeschke
Copy link
Member

Thanks @snitish

@snitish
Copy link
Contributor Author

snitish commented Jan 21, 2025

Thanks @mroeschke for approving. Since there are some leftover reduction operations in the original list that still need to support skipna, could you please reopen the original issue #15675 ?

@snitish snitish deleted the issue15675 branch January 21, 2025 19:12
@mroeschke
Copy link
Member

Sure thing done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: enable skipna on groupby reduction ops
2 participants