Update automation #114
Merged
Update automation #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because that's what it does, it doesn't test
so we can get the pull request number
default upstream php is 8.1 so we can not test older than that
bedrock no longer supports
make sure we're getting the latest stuff
when deploy-public-upstream is run
pwtyler
previously approved these changes
Apr 8, 2024
Comment on lines
+2
to
+4
| permissions: | ||
| pull-requests: read | ||
| contents: read |
There was a problem hiding this comment.
because we're pulling down the repository and doing a bunch of stuff on it. the tests failed to run without the permissions.
|
|
||
| if [ "$(ls -A "$sagedir")" ]; then | ||
| echo "${red}Directory not empty!${normal}" | ||
| if [ "$is_ci" -eq 1 ]; then |
There was a problem hiding this comment.
Suggested change
| if [ "$is_ci" -eq 1 ]; then | |
| if [[ "$is_ci" == 1 ]]; then |
-eq will error if is_ci is an empty string. I don't see where it's coming from though so possibly this is unnecessary.
Co-authored-by: Phil Tyler <[email protected]>
jazzsequence
added a commit
that referenced
this pull request
Jul 31, 2024
* rename testing.yml to sync-default.yml because that's what it does, it doesn't test * bump checkout version * bump ssh-add version * give prs read access so we can get the pull request number * add contents perms * drop php 8.0 testing default upstream php is 8.1 so we can not test older than that * fix typo * allow deletion of test sage directory if on ci * don't fail fast if one of the tests fails * wait for the operation to complete * allow steps in the build artifact step to fail * check for an existing named multidev before creating * silence the workflow wait * use latest stable node * drop php 7.4 tests bedrock no longer supports * rename workflow * use the right command * update circle image * better handling for multidev matching * use latest lts * use current node version * switch lint/test to pull request * bump node setup earleir * just wait 15 seconds * don't cache dependencies * add composer diff * update php requirement * run composer update instead of install make sure we're getting the latest stuff * only run check-commits on release pushes when deploy-public-upstream is run * move stuff around * move the filter back into the deploy-public-upstream job * filter check-commits on release, too * add specific triggers for pull_request * remove write permission for composer-diff Co-authored-by: Phil Tyler <[email protected]> --------- Co-authored-by: Phil Tyler <[email protected]>
jazzsequence
added a commit
that referenced
this pull request
Aug 1, 2024
* rename testing.yml to sync-default.yml because that's what it does, it doesn't test * bump checkout version * bump ssh-add version * give prs read access so we can get the pull request number * add contents perms * drop php 8.0 testing default upstream php is 8.1 so we can not test older than that * fix typo * allow deletion of test sage directory if on ci * don't fail fast if one of the tests fails * wait for the operation to complete * allow steps in the build artifact step to fail * check for an existing named multidev before creating * silence the workflow wait * use latest stable node * drop php 7.4 tests bedrock no longer supports * rename workflow * use the right command * update circle image * better handling for multidev matching * use latest lts * use current node version * switch lint/test to pull request * bump node setup earleir * just wait 15 seconds * don't cache dependencies * add composer diff * update php requirement * run composer update instead of install make sure we're getting the latest stuff * only run check-commits on release pushes when deploy-public-upstream is run * move stuff around * move the filter back into the deploy-public-upstream job * filter check-commits on release, too * add specific triggers for pull_request * remove write permission for composer-diff Co-authored-by: Phil Tyler <[email protected]> --------- Co-authored-by: Phil Tyler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make this repository public again, we needed to create a new Pantheon user with new secrets. While all of those things happened in the background with repository secrets, this PR makes some changes to the existing automations (including the Sage Theme Install test, which is why we needed a SSH key in the first place) to update and optimize them.
The
check commitstest has been moved to just run on pushes toreleaseas part of thedeploy-public-upstreamworkflow.Working Sage Install tests can be found here: https://github.com/pantheon-systems/wordpress-composer-managed/actions/runs/8576488930