[CMSP-132] shellcheck devops scripts #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in customer repositories it will not
so customers don't need to use it or delete it but we can run it
pwtyler
reviewed
May 7, 2024
this is the one I'm worried about breaking
pwtyler
approved these changes
May 8, 2024
Co-authored-by: Phil Tyler <[email protected]>
jazzsequence
added a commit
that referenced
this pull request
Jul 31, 2024
* shcllcheck changes * add devops/scripts/*.sh to lint:bash * only shellcheck devops/scripts if it exists in customer repositories it will not * make devops linting separate from lint tests so customers don't need to use it or delete it but we can run it * add lint:devops to testing * break nested subshell * leave the code and ignore the lint this is the one I'm worried about breaking * use `# shellcheck source` instead of `# shellcheck disable` * Update devops/scripts/check-commits.sh Co-authored-by: Phil Tyler <[email protected]> --------- Co-authored-by: Phil Tyler <[email protected]>
jazzsequence
added a commit
that referenced
this pull request
Aug 1, 2024
* shcllcheck changes * add devops/scripts/*.sh to lint:bash * only shellcheck devops/scripts if it exists in customer repositories it will not * make devops linting separate from lint tests so customers don't need to use it or delete it but we can run it * add lint:devops to testing * break nested subshell * leave the code and ignore the lint this is the one I'm worried about breaking * use `# shellcheck source` instead of `# shellcheck disable` * Update devops/scripts/check-commits.sh Co-authored-by: Phil Tyler <[email protected]> --------- Co-authored-by: Phil Tyler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the linting Composer scripts in the project and adds a new
lint:devopsscript to be used in automation and Pantheon engineers. It makes sure that only existing devops scripts are linted.This PR also updates the scripts to shellcheck standards.