replace tput with a safe_tput function
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows tput to be used on systems that support it but does not error if tput is not available
we're unnecessarily waiting because we never actually pushed anything
pwtyler
reviewed
Jun 25, 2024
pwtyler
approved these changes
Jun 25, 2024
jazzsequence
added a commit
that referenced
this pull request
Jul 31, 2024
* replaces tput with a safe_tput function allows tput to be used on systems that support it but does not error if tput is not available * add a git push after the sage theme is built and installed we're unnecessarily waiting because we never actually pushed anything * remove ||
jazzsequence
added a commit
that referenced
this pull request
Aug 1, 2024
* replaces tput with a safe_tput function allows tput to be used on systems that support it but does not error if tput is not available * add a git push after the sage theme is built and installed we're unnecessarily waiting because we never actually pushed anything * remove ||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that appears in Workflow logs in the Pantheon dashboard.
The terminal environment used to render the workflow logs does not support
tputand does not have a$TERMvalue, so setting the colors at the top ofhelpers.shthrows errors.The
safe_tputfunction allowstputto be used on systems that support it but does not error iftputis not available. In the cases when this is running (e.g. in Workflow logs) the colors are not really important and are only used when the symlinks are being created duringcomposer install.This PR also adds a
git pushafter the Sage theme is built and installed because the script waits for an operation (e.g.sync_code) that isn't actually running. This is likely something that was removed but we still have theworkflow:waitcommand in place.