Update PHP version to 8.1 and other updates to helpers.sh
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we can test it
jazzsequence
changed the title
helpers.sh
pwtyler
approved these changes
Jun 26, 2024
…heck we can also remove the conditional around activation because if it's in the list, we should be able to activate it
jazzsequence
added a commit
that referenced
this pull request
Jul 31, 2024
* set the default php version to 8.1 * update the update_php function to update to 8.1 at minimum * allow the update_php function to be run independently so we can test it * add tests for the updated update_php function * update the test script to add bats tests * update the echo to be more accurate * add more verbose inline docs * bail if we can't copy the file * ensure the job runner has permission to write to the filesystem * update the sed command to work cross-platform maybe.... * don't bail out of the script entirely in the update php script if in CI * bail early (and don't try to activate) if the theme wasn't found * remove line breaks or spaces from the theme name * echo the themelist so we can see what's being grepped * change the grep to be more inclusive * use grep -q instead of -w * normalize genrenated theme names * move the messaging about the theme not being in the list up to that check we can also remove the conditional around activation because if it's in the list, we should be able to activate it
jazzsequence
added a commit
that referenced
this pull request
Aug 1, 2024
* set the default php version to 8.1 * update the update_php function to update to 8.1 at minimum * allow the update_php function to be run independently so we can test it * add tests for the updated update_php function * update the test script to add bats tests * update the echo to be more accurate * add more verbose inline docs * bail if we can't copy the file * ensure the job runner has permission to write to the filesystem * update the sed command to work cross-platform maybe.... * don't bail out of the script entirely in the update php script if in CI * bail early (and don't try to activate) if the theme wasn't found * remove line breaks or spaces from the theme name * echo the themelist so we can see what's being grepped * change the grep to be more inclusive * use grep -q instead of -w * normalize genrenated theme names * move the messaging about the theme not being in the list up to that check we can also remove the conditional around activation because if it's in the list, we should be able to activate it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
helpers.shscript'supdate_phpfunction to default to a minimum of PHP 8.1 since Sage no longer supports 8.0.The update_php function has therefore been updated to check for a minimum of 8.1 but additionally updates have been made so that
update_phpcan be called directly from the script outside of the sage install workflow, so we can test that component separately.BATS tests have been created to test the
update_phpfunction for all versions from 7.4 - 8.3.This PR also makes the following minor(ish) adjustments to the sage install script workflow:
/dev/nullso a WP-CLI warning is not thrown if theMULTISITEconstant does not exist)