Refactor core resource URL filtering and multisite handling #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
single site test (despite the site name): https://dev-wpcm-subdirectory-test.pantheonsite.io/ multisite tests coming |
|
subdirectory site test: https://dev-test-156-subdir.pantheonsite.io/ |
pwtyler
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156
This pull request refactors the
fix_core_resource_urlsfunction to move the multisite handling into the function. It introduces a new functionfilter_core_resource_urlsto run thefix_core_resource_urlsfilter oninit. This replaces the previous version that wrapped a$filtersvariable in the global scope inside the multisite check.It also simplifies the logic in
adjust_main_site_urls