[SITE-1957] Single sites and subdirectory multisites still missing some css / js resources #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tested on subdom, subdir and single sites
pwtyler
approved these changes
Aug 30, 2024
jazzsequence
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the last update that does not fully fix the broken paths for some core resources on some sites (single site and subdirectory multisite).
This PR adds an
is_multisitecheck back into the filters that handle the url rewriting.This was discovered on a one-off test site of mine and confirmed by a customer using the WPCM upstream (and a custom upstream based off it). Confirmed working in both cases and it was confirmed that this issue does not exist on subdomain multisite and subdomain multisite continues to be unaffected by the change.
tested on subdom, subdir and single sites