Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect cmake variable name RUCKIG_VERSION should be ruckig_VERSION #220

Closed
wants to merge 1 commit into from

Conversation

Levi-Armstrong
Copy link

No description provided.

@pantor
Copy link
Owner

pantor commented Jan 22, 2025

While setting the variable RUCKIG_VERSION is superfluous in general (as we should just use ruckig_VERSION instead), both variables have the exact same value. I just double checked via:

if(${RUCKIG_VERSION} STREQUAL ${ruckig_VERSION})
  message(STATUS "Version string is equal.")
endif()

So what is the error that you're trying to fix?

@pantor
Copy link
Owner

pantor commented Jan 22, 2025

I just cleaned this variable completely in 4f3e8c2.

@pantor pantor closed this Jan 22, 2025
@Levi-Armstrong Levi-Armstrong deleted the patch-1 branch January 22, 2025 18:57
@Levi-Armstrong
Copy link
Author

The issue I ran into was when generating the Debian using cpack and it had an empty version. After this change the issue went away. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants