Remove cruft from the ArgSplitter. #21812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
commented
Jan 8, 2025
| @@ -247,22 +234,6 @@ def _consume_flags(self) -> list[str]: | |||
| flags.append(flag) | |||
| return flags | |||
|
|
|||
| def _descope_flag(self, flag: str, default_scope: str) -> tuple[str, str]: | |||
There was a problem hiding this comment.
This is no longer called anywhere.
benjyw
commented
Jan 8, 2025
| @@ -97,19 +97,6 @@ def __init__(self, known_scope_infos: Iterable[ScopeInfo], buildroot: str) -> No | |||
| # We store in reverse order, for efficient popping off the end. | |||
| self._unconsumed_args: list[str] = [] | |||
|
|
|||
| # We allow --scope-flag-name anywhere on the cmd line, as an alternative to ... | |||
There was a problem hiding this comment.
This was only used in _descope_flag() below, which is no longer called.
benjyw
commented
Jan 8, 2025
| @@ -228,22 +212,6 @@ def test_passthru_args(splitter: ArgSplitter) -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| def test_subsystem_flags(splitter: ArgSplitter) -> None: | |||
There was a problem hiding this comment.
We no longer use ArgSplitter to extract flags (we only use it to figure out goals and specs), so this test now just recapitulates other tests in this file.
tdyas
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #21811 we removed some unneeded logic from ArgSplitter.
This PR cleans up some cruft remaining from that change.