fix flaky failure in export_integration_test.py (Cherry-pick of #21756)
#21821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WorkerPants
added
the
category:internal
cognifloyd
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/python/pants/backend/python/goals/export_integration_test.pywas failing for me consistently in a PR of mine and onmainlocally. Not sure why it passes elsewhere.See this failure for example: https://github.com/pantsbuild/pants/actions/runs/12306576175/job/34349676205?pr=21745#step:10:478
The test is checking whether a venv activation script has a certain prompt with both a resolve name and the Python version. The test also checks whether the quote character starting that string begins with a double-quote character.
On my system for
mainand in the PR on CI, that quote character became a single quote instead so the test fails.Use a regex and allow either quote character.