-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(demo): Reconstruct it using gtk-rust-template #2
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't use the template because I think it's too much for a simple demo. Not sure that you actually need resources and translations. Publishing to flathub can be useful
origami-demo/meson.build
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think meson actually complicates testing. Are you still able to open the demo on a specific page by cargo run page
?
Probably it's required for i18n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just using cargo run
isn't that easy anymore. That's because Meson does some things like i18n as you said, setting version, constructing the desktop file, etc. Btw, I've just added an About dialog.
Is there a special use case of opening a page directly. I think, maybe when you work on a widget you want just hit arrow up in the console to get the previous cargo command and then start directly with that page?
As a workaround, we could maybe save the last page as a gsetting when running in debug mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gsetting for the last page is a good solution, just make sure that it doesn't crash if the setting was changed to an incorrect one. I think that resetting to the main page is okay for that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can that be translated to blueprint and moved outside of resources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved it out. But AFAIK to make it a blp I have to define it as a resource so that is compiled beforehand.
df12fd6
to
657b82a
Compare
The demo was recreated using gtk-rust-template and renamed to origami-demo. This makes it more available for people who just want to build it quickly and try it out. Maybe we could also publish it on flathub at some point.
657b82a
to
fbc8ecd
Compare
The demo was recreated using gtk-rust-template and renamed to origami-demo. This makes it more available for people who just want to build it quickly and try it out. Maybe we could also publish it on flathub at some point.