Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle all revm errors #14574

Merged
merged 1 commit into from
Feb 19, 2025
Merged

chore: handle all revm errors #14574

merged 1 commit into from
Feb 19, 2025

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Feb 18, 2025

this was previously #[allow(unreachable_patterns)] because this included optimism errors

we can handle all of these and exhaustively

this maps a new prague error to gas too low, see docs

@mattsse mattsse requested a review from Rjected as a code owner February 18, 2025 23:32
@mattsse mattsse added A-rpc Related to the RPC implementation A-execution Related to the Execution and EVM labels Feb 18, 2025
@mattsse mattsse enabled auto-merge February 18, 2025 23:33
@mattsse mattsse requested a review from klkvr February 18, 2025 23:33
@mattsse mattsse added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit cec1c11 Feb 19, 2025
43 checks passed
@mattsse mattsse deleted the matt/handle-all-evm-errors branch February 19, 2025 01:42
loocapro pushed a commit to loocapro/reth that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM A-rpc Related to the RPC implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants