Modified op-reth to always use all OP bootnodes when none are explicitly provided #14603 #14619
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly provided. paradigmxyz#14603 this is the linked git issue paradigmxyz#14603
Ayushdubey86
requested review from
mattsse,
Rjected and
fgimenez
as code owners
emhane
added
A-devp2p
emhane
requested changes
Feb 21, 2025
Comment on lines
+734
to
+736
| params::V5OPBootnodes.to_vec() | ||
| } else { | ||
| params::V5OPTestnetBootnodes.to_vec() |
There was a problem hiding this comment.
these constants can be declared in the config module
Co-authored-by: Emilia Hane <[email protected]>
mattsse
requested changes
Feb 21, 2025
Comment on lines
+734
to
+736
| params::V5OPBootnodes.to_vec() | ||
| } else { | ||
| params::V5OPTestnetBootnodes.to_vec() |
There was a problem hiding this comment.
actually we can make this redundant
if we change just change this to is_optimism() and is_testnet():
reth/crates/chainspec/src/spec.rs
Lines 646 to 647 in 81cff4a
|
I'll make this change and push it by eod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the linked git issue Issue-14603
@mattsse