Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): Implement EIP-7685 requests and EIP-2935 syscall in create_reorg_head #14623

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nethoxa
Copy link

@nethoxa nethoxa commented Feb 20, 2025

There were some TODOs and missing code regarding changes for the Prague upgrade. This PR adds the following:

  • Changes the call to apply_beacon_root_contract_call to apply_pre_execution_changes, so that both the beacon root and the parent hash syscalls are processed
  • Processes EIP-7685 requests, as well as upgrades the returned ExecutionPayloadSidecar

@emhane emhane added the A-engine Related to the engine implementation label Feb 21, 2025
@emhane emhane requested a review from klkvr February 21, 2025 09:26
Copy link
Member

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic does not run right now

// .maybe_reorg(
// ctx.blockchain_db().clone(),
// ctx.components().evm_config().clone(),
// reth_payload_validator::ExecutionPayloadValidator::new(ctx.chain_spec()),
// node_config.debug.reorg_frequency,
// node_config.debug.reorg_depth,
// )

But ideally this should use BlockExecutionStrategy instead of directly relying on SystemCaller, like we do in payload builder since #14609

For now you can just manually setup EthBlockExecutionStrategy until we have an easy way to expose it to this part of code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-engine Related to the engine implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants