Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 8.4 deprecations #194

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Fix PHP 8.4 deprecations #194

merged 1 commit into from
Jan 23, 2025

Conversation

acbramley
Copy link
Contributor

Fixes 3 PHP 8.4 deprecations due to implicit nullables:

Deprecated: ParagonIE\Halite\Stream\ReadOnlyFile::__construct(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /data/vendor/paragonie/halite/src/Stream/ReadOnlyFile.php on line 81

Deprecated: ParagonIE\Halite\File::checksum(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /data/vendor/paragonie/halite/src/File.php on line 104

Deprecated: ParagonIE\Halite\File::checksumData(): Implicitly marking parameter $key as nullable is deprecated, the explicit nullable type must be used instead in /data/vendor/paragonie/halite/src/File.php on line 594

@paragonie-security paragonie-security merged commit 8f8974c into paragonie:master Jan 23, 2025
5 checks passed
@acbramley acbramley deleted the php8.4-deprecations branch January 23, 2025 21:43
@spaze spaze mentioned this pull request Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acbramley @paragonie-security