Forward compatibility with v5 #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmichalski
force-pushed
the
v4-fwd-compat
branch
from
4148a77 to
83baeea
Compare
marmichalski
force-pushed
the
v4-fwd-compat
branch
from
83baeea to
452b5b5
Compare
marmichalski
commented
Feb 21, 2025
| // Number of pieces that go into MAC (header, first nonce, salt, ciphertext) -> 4 | ||
| if ($config->USE_PAE) { | ||
| // Number of pieces: | ||
| sodium_crypto_generichash_update($mac, pack('P', 4)); |
There was a problem hiding this comment.
This is not 100% compatible, as with aad you have 5 pieces. Don't think there is anything one can do here though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds forward compatibility with v5 ciphertexts in v4. This (maybe) resolves #187.
In distributed environments where halite is used, it is pretty hard (impossible) to upgrade all services at the same time, when one service starts using halite v5, services using v4 can't understand what they're saying 😭
All of the stuff here is copied over from v5 with minimal changes where needed.
I can try to provide some tests verifying that v4 indeed understands v5.