-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track and test dependencies' 'test-next' branch #117
Track and test dependencies' 'test-next' branch #117
Conversation
Nightly run triggered on my fork: https://github.com/tgonzalezorlandoarm/parsec-tool/actions/runs/6980447931 |
87f7e9b
to
7d8241e
Compare
We do clone parsec repo as part of the CI so does it make sense to use the dependency_cross_matcher.py and release_tracking.py scripts from the parsec repo itself? That way it is easier to maintain and avoids duplication. |
Agreed 100%, thanks! |
parsec-tool depends on several repositories under the parallaxsecond organization. * Add a flag option (--test-next-branch-tracking) in ci.sh to track the 'test-next' branches of said repositories and test parsec-tool with those updates. Signed-off-by: Tomás González <[email protected]>
parsec-tool depends on several repositories under the parallaxsecond organization. Currently, when testing the main branch of parsec-tool, fixed versions of the latest released crates of those repositories are being used. A problem may arise when there is a change introduced in the main/'test-next' branch of those repositories that would break parsec-tool when updating/incorporating that change. This is currently not being tested in our CI. As parsec-tool release is dependent on having published the dependencies' crates, there are issues that will not be caught until the publishing of said crates. * Add a nightly job that uses ci.sh --test-next-branch-tracking to test the test-next release branches of parallaxsecond repositories and spot issues before release. These job makes use of previously defined re-usable actions. Signed-off-by: Tomás González <[email protected]>
7d8241e
to
875e82e
Compare
Strange these don't show up as errors from the nightly CI run here!!
|
I think this was done by design, please check this comment Anyways, this is a valid point that there's no need to run these tests in this job. I will change it when I do the change to using ci.py instead of ci.sh |
parsec-tool depends on several repositories under the parallaxsecond organization.
Currently, when testing the main branch of parsec, fixed versions of the latest released crates of those repositories are being used.
A problem may arise when there is a change introduced in the main/'test-next' branch of those repositories that would break parsec when updating/incorporating that change. This is currently not being tested in our CI.
As parsec-tool release is dependent on having published the dependencies' crates, there are issues that will not be caught until the publishing of said crates.
Add nightly jobs that use ci.sh --test-next-branch-tracking to test the next release branches of parallaxsecond repositories and spot issues before release. These jobs makes use of parsec's utils/release_tracking.py
Please see parallaxsecond/parsec#732