Add references to RFC 4493 in comments about AesCMac. #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
previously approved these changes
Nov 8, 2023
|
Ugh, it seems merging some other PR broke yours. Would you be able to resolve it? If not please say we can assist. Thanks! 👋 |
ionut-arm
previously approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Thank you for the patch!
One thing I'm thinking about, actually - though not for this PR - is that maybe we can integrate Wycheproof in our tests, rather than having to manage our own list of test vectors. I'll raise an issue to track this :)
Wow, this looks highly relevant! Thanks for linking. |
|
@xaqq could you please rebase and resolve the conflicts so that we can merge the PR? :) |
Signed-off-by: Arnaud Kapp <[email protected]>
hug-dev
approved these changes
Jan 15, 2024
wiktor-k
approved these changes
Jan 15, 2024
|
Thanks for your time @xaqq! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for merging previous PR exposing AesCMac.
Test vectors were coming from RFC 4493 so this commit clarifies that.
(Also performs the test against the 4 available test data of the RFC)