error[E0308]: mismatched types --> core/src/server/method_response.rs:520:63 | 520 | let batch = BatchResponseBuilder::new_with_limit(63).append(&method).unwrap_err(); | ------ ^^^^^^^ expected `MethodResponse`, found `&MethodResponse` | | | arguments to this method are incorrect | note: method defined here --> core/src/server/method_response.rs:300:9 | 300 | pub fn append(&mut self, response: MethodResponse) -> Result<(), MethodResponse> { | ^^^^^^ ------------------------ help: consider removing the borrow | 520 - let batch = BatchResponseBuilder::new_with_limit(63).append(&method).unwrap_err(); 520 + let batch = BatchResponseBuilder::new_with_limit(63).append(method).unwrap_err(); |

mismatched types: core/src/server/method_response.rs#L501

error[E0308]: mismatched types --> core/src/server/method_response.rs:501:18 | 501 | builder.append(&m1).unwrap(); | ------ ^^^ expected `MethodResponse`, found `&MethodResponse` | | | arguments to this method are incorrect | note: method defined here --> core/src/server/method_response.rs:300:9 | 300 | pub fn append(&mut self, response: MethodResponse) -> Result<(), MethodResponse> { | ^^^^^^ ------------------------ help: consider removing the borrow | 501 - builder.append(&m1).unwrap(); 501 + builder.append(m1).unwrap(); |

mismatched types: core/src/server/method_response.rs#L500

error[E0308]: mismatched types --> core/src/server/method_response.rs:500:18 | 500 | builder.append(&m1).unwrap(); | ------ ^^^ expected `MethodResponse`, found `&MethodResponse` | | | arguments to this method are incorrect | note: method defined here --> core/src/server/method_response.rs:300:9 | 300 | pub fn append(&mut self, response: MethodResponse) -> Result<(), MethodResponse> { | ^^^^^^ ------------------------ help: consider removing the borrow | 500 - builder.append(&m1).unwrap(); 500 + builder.append(m1).unwrap(); |

mismatched types: core/src/server/method_response.rs#L485

error[E0308]: mismatched types --> core/src/server/method_response.rs:485:18 | 485 | builder.append(&method).unwrap(); | ------ ^^^^^^^ expected `MethodResponse`, found `&MethodResponse` | | | arguments to this method are incorrect | note: method defined here --> core/src/server/method_response.rs:300:9 | 300 | pub fn append(&mut self, response: MethodResponse) -> Result<(), MethodResponse> { | ^^^^^^ ------------------------ help: consider removing the borrow | 485 - builder.append(&method).unwrap(); 485 + builder.append(method).unwrap(); |

Check style

Clippy had exited with the 101 exit code

Check

Process completed with exit code 1.

Run tests Ubuntu

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

Run tests macos

The process '/Users/runner/.cargo/bin/cargo' failed with exit code 101

Run tests Windows

The process 'C:\Users\runneradmin\.cargo\bin\cargo.exe' failed with exit code 101

Check rustdoc

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Check rustdoc

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Check rustdoc

this expression creates a reference which is immediately dereferenced by the compiler: server/src/middleware/http/proxy_get_request.rs#L216

warning: this expression creates a reference which is immediately dereferenced by the compiler --> server/src/middleware/http/proxy_get_request.rs:216:54 | 216 | let error = serde_json::from_slice::<ErrorResponse>(&bytes) | ^^^^^^ help: change this to: `bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

this `map_or` is redundant: server/src/transport/http.rs#L21

warning: this `map_or` is redundant --> server/src/transport/http.rs:21:2 | 21 | / content_type.and_then(|val| val.to_str().ok()).map_or(false, |content| { 22 | | content.eq_ignore_ascii_case("application/json") 23 | | || content.eq_ignore_ascii_case("application/json; charset=utf-8") 24 | | || content.eq_ignore_ascii_case("application/json;charset=utf-8") ... | 27 | | || content.eq_ignore_ascii_case("application/json-rpc; charset=utf-8") 28 | | }) | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `#[warn(clippy::unnecessary_map_or)]` on by default help: use is_some_and instead | 21 ~ content_type.and_then(|val| val.to_str().ok()).is_some_and(|content| { 22 ~ content.eq_ignore_ascii_case("application/json") 23 ~ || content.eq_ignore_ascii_case("application/json; charset=utf-8") 24 ~ || content.eq_ignore_ascii_case("application/json;charset=utf-8") 25 ~ || content.eq_ignore_ascii_case("application/json-rpc") 26 ~ || content.eq_ignore_ascii_case("application/json-rpc;charset=utf-8") 27 ~ || content.eq_ignore_ascii_case("application/json-rpc; charset=utf-8") 28 ~ }) |

this expression creates a reference which is immediately dereferenced by the compiler: server/src/middleware/http/proxy_get_request.rs#L216