-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enha: send original error response in ProxyGetRequest #1516
base: master
Are you sure you want to change the base?
Conversation
I tried using an enum instead of deserializing in two places, but it did not work, serde kept failing with "data did not match any variant of untagged enum". I think it has something to do with untagged enums expecting all parameters of the json object to be in the variant's struct, while structs will deserialize even if the json contains extra fields. |
Yes, we are using serde_json::value::RawValue which doesn't work with untagged enums serde-rs/json#779 |
If you merge master then the UI tests should pass I fixed it right now, new stable rust version broke it |
#[derive(serde::Deserialize, serde::Serialize, Debug)] | ||
struct ErrorResponse<'a> { | ||
#[serde(borrow)] | ||
error: &'a serde_json::value::RawValue, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error: &'a serde_json::value::RawValue, | |
error: ErrorObject<'a>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied this by mistake, if it is ok here to directly deserialize to the error object, why not also directly deserialize the result in the success response?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think in this case we can just do serde_json::from_slice::<ErrorObject>(&bytes)
and not have the ErrorResponse struct at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I think in this case we can just do serde_json::from_slice::<ErrorObject>(&bytes)
This is incorrect, my bad
Co-authored-by: Niklas Adolfsson <[email protected]>
closes #1515