Disallow duplicate indexes using constant evaluation #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improve error message * Apply suggestions from code review Co-authored-by: Bastian Köcher <[email protected]> * finally understanding rust const environment * fmt --------- Co-authored-by: Bastian Köcher <[email protected]>
gui1117
approved these changes
Jan 25, 2025
|
I was basing my PR on top of yours, so I re-opened it. @bkchr if you like it we can merge it |
bkchr
approved these changes
Jan 25, 2025
This was referenced Jan 27, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
following a suggestion from here #628 (comment)
Notes
It seems that it's not possible to have a good error message this way, as
format!in cant be used in constant_blocks, so string interpolation is not possible unless we pick upconst_formatand re-export it from the library.