[mq pallet] Custom next queue selectors #6059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
This was referenced Jan 27, 2025
muharem
approved these changes
Feb 4, 2025
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
/cmd prdoc --bump minor --audience runtime_dev |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
/cmd bench --pallet pallet_message_queue |
|
Command "bench --pallet pallet_message_queue" has started 🚀 See logs here |
|
Command "bench --pallet pallet_message_queue" has finished ✅ See logs here Subweight results:
Command output:❌ Failed to build asset-hub-westend |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
/cmd bench --pallet pallet_message_queue |
|
Command "bench --pallet pallet_message_queue" has started 🚀 See logs here |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
/cmd bench --pallet pallet_message_queue |
|
Command "bench --pallet pallet_message_queue" has started 🚀 See logs here |
|
Command "bench --pallet pallet_message_queue" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
|
Command "bench --pallet pallet_message_queue" has failed ❌! See logs here Command output:✅ Successful benchmarks of runtimes/pallets: |
|
/cmd bench --pallet pallet_message_queue |
|
Command "bench --pallet pallet_message_queue" has started 🚀 See logs here |
|
Command "bench --pallet pallet_message_queue" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
/cmd prdoc --audience runtime_dev --bump patch --force |
…mp patch --force'
ggwpez
commented
Feb 12, 2025
ggwpez
commented
Feb 13, 2025
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
AKJUS
approved these changes
Feb 14, 2025
clangenb
pushed a commit
to clangenb/polkadot-sdk
that referenced
this pull request
Feb 19, 2025
Changes: - Expose a `force_set_head` function from the `MessageQueue` pallet via a new trait: `ForceSetHead`. This can be used to force the MQ pallet to process this queue next. - The change only exposes an internal function through a trait, no audit is required. ## Context For the Asset Hub Migration (AHM) we need a mechanism to prioritize the inbound upward messages and the inbound downward messages on the AH. To achieve this, a minimal (and no breaking) change is done to the MQ pallet in the form of adding the `force_set_head` function. An example use of how to achieve prioritization is then demonstrated in `integration_test.rs::AhmPrioritizer`. Normally, all queues are scheduled round-robin like this: `| Relay | Para(1) | Para(2) | ... | Relay | ... ` The prioritizer listens to changes to its queue and triggers if either: - The queue processed in the last block (to keep the general round-robin scheduling) - The queue did not process since `n` blocks (to prevent starvation if there are too many other queues) In either situation, it schedules the queue for a streak of three consecutive blocks, such that it would become: `| Relay | Relay | Relay | Para(1) | Para(2) | ... | Relay | Relay | Relay | ... ` It basically transforms the round-robin into an elongated round robin. Although different strategies can be injected into the pallet at runtime, this one seems to strike a good balance between general service level and prioritization. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: muharem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
force_set_headfunction from theMessageQueuepallet via a new trait:ForceSetHead. This can be used to force the MQ pallet to process this queue next.Context
For the Asset Hub Migration (AHM) we need a mechanism to prioritize the inbound upward messages and the inbound downward messages on the AH. To achieve this, a minimal (and no breaking) change is done to the MQ pallet in the form of adding the
force_set_headfunction.An example use of how to achieve prioritization is then demonstrated in
integration_test.rs::AhmPrioritizer. Normally, all queues are scheduled round-robin like this:| Relay | Para(1) | Para(2) | ... | Relay | ...The prioritizer listens to changes to its queue and triggers if either:
nblocks (to prevent starvation if there are too many other queues)In either situation, it schedules the queue for a streak of three consecutive blocks, such that it would become:
| Relay | Relay | Relay | Para(1) | Para(2) | ... | Relay | Relay | Relay | ...It basically transforms the round-robin into an elongated round robin. Although different strategies can be injected into the pallet at runtime, this one seems to strike a good balance between general service level and prioritization.