Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't run CI on draft PRs #7518

Merged
merged 14 commits into from
Feb 18, 2025
Merged

ci: don't run CI on draft PRs #7518

merged 14 commits into from
Feb 18, 2025

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam commented Feb 10, 2025

PR adds a resuable workflow that prevents CI to run on draft PRs. To run CI on draft a new label is introduced: A5-run-CI. To run the CI the label should be added and en empty commit should be pushed.

close https://github.com/paritytech/ci_cd/issues/1099
close #7168

@alvicsam alvicsam marked this pull request as ready for review February 10, 2025 13:03
@alvicsam alvicsam requested review from a team as code owners February 10, 2025 13:03
@alvicsam alvicsam added the R0-silent Changes should not be mentioned in any release notes label Feb 10, 2025
@alvicsam alvicsam changed the title [WIP]ci: don't run CI on draft PRs ci: don't run CI on draft PRs Feb 10, 2025
@mutantcornholio
Copy link
Contributor

mutantcornholio commented Feb 10, 2025

A lot of times I actually create draft PRs specifically to run CI.
Also, if CI's failing and I need to fix it, I move the PR to draft, so it wouldn't get reviewed, as it'll be changed anyway.
Why do we want to do this anyway? UPD: I've read the issues

@alvicsam alvicsam marked this pull request as draft February 14, 2025 13:28
@alvicsam
Copy link
Contributor Author

Talked to @mutantcornholio, I'll add a condition that gives ability to run the CI in draft when there is a Run-CI label.

@alvicsam alvicsam added the A5-run-CI Run CI on draft PR label Feb 18, 2025
@alvicsam alvicsam removed the A5-run-CI Run CI on draft PR label Feb 18, 2025
@alvicsam alvicsam added the A5-run-CI Run CI on draft PR label Feb 18, 2025
@alvicsam alvicsam marked this pull request as ready for review February 18, 2025 12:31
@alvicsam alvicsam removed the A5-run-CI Run CI on draft PR label Feb 18, 2025
@alvicsam alvicsam added this pull request to the merge queue Feb 18, 2025
Merged via the queue into master with commit cc8f6e6 Feb 18, 2025
444 of 463 checks passed
@alvicsam alvicsam deleted the as-ci-skip-draft branch February 18, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't run CI checks on draft PR
3 participants